Conversation
|
both commands work: and |
|
Sorry for the huge PR. |
|
Is the documentation a copy from dev ? (except for bwamem2) |
|
I checked-out most of the files from |
| [BWA-mem2](https://github.com/bwa-mem2/bwa-mem2) is a software package for mapping low-divergent sequences against a large reference genome. | ||
|
|
||
| #### GATK MarkDuplicatesSpark | ||
| Such files are intermediate and not kept in the final files delivered to users. |
There was a problem hiding this comment.
It is a bit unclear for me here, which files are not delivered to the user. The mapped bams? Similar in the BWA section
There was a problem hiding this comment.
Yes, especially since they're not merged.
But yeah, not very clear
| bam_bwamem2 = BWAMEM2_MEM.out | ||
| } | ||
|
|
||
| bam_bwamem2 = bam_bwamem2.mix(bwa_mem_out) |
There was a problem hiding this comment.
I think we should use just bam_bwa or something. If bwamem2 was not used for mapping, the channel will still be called that for the remainder of the pipeline
There was a problem hiding this comment.
Or will this not work because of empty channels or what not?I suppose we can also work on naming as we go, since all the things are changing so much still
| @@ -0,0 +1,59 @@ | |||
| /* | |||
There was a problem hiding this comment.
These are the functions from the modules repo right? We should probably find a common place for them, otherwise we will have them x-times in the end (if that works)
There was a problem hiding this comment.
Actually just used nf-core modules install . bwa/index
Maybe it's something that need to be fixed within the nf-core/modules repo
There was a problem hiding this comment.
ok, maybe this can be discussed in the modules channel. Could be tricky to figure out during the installation whether another module has been installed and thus the functions are there.
There was a problem hiding this comment.
If it's always the same functions, then it can be in a specific path within the modules folder.
Should be easy to check if it exists
There was a problem hiding this comment.
I guess for now, here we can leave it as is
ok, I have not read about everything in the docu now. Focused on the changes for the aligner. Skimmed only over the rest |
Co-authored-by: FriederikeHanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
2 participants
nf-core/sarek pull request
Many thanks for contributing to nf-core/sarek!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md